This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author dw
Recipients alanmcintyre, dw, jcea, kasal, serhiy.storchaka
Date 2014-11-11.03:16:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1415675804.01.0.780876925492.issue16569@psf.upfronthosting.co.za>
In-reply-to
Content
Compared to the cost of everything else ZipExtFile must do (e.g. 4kb string concatenation in a loop, zlib), its surprising that lseek() would measurable at all. 

The attached file 'patch' is the minimal change I tested. It represents, in terms of computation and system call overhead, all required to implement the "seek before read" solution to simultaneous access. On OSX, churning over ever member of every ZIP in my downloads directory (about 400mb worth), this change results in around 0.9% overhead compared to the original module.

Subsequently I'm strongly against the patch here. It is in effect papering over an implementation deficiency of the current zipfile module, one that could easily and cheaply be addressed.

(My comment on this ticket is in the context of the now-marked-duplicate issue22842).
History
Date User Action Args
2014-11-11 03:16:44dwsetrecipients: + dw, jcea, alanmcintyre, kasal, serhiy.storchaka
2014-11-11 03:16:44dwsetmessageid: <1415675804.01.0.780876925492.issue16569@psf.upfronthosting.co.za>
2014-11-11 03:16:43dwlinkissue16569 messages
2014-11-11 03:16:43dwcreate