Author rhettinger
Recipients ezio.melotti, rhettinger, serhiy.storchaka, terry.reedy
Date 2014-11-09.20:17:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1415564269.36.0.990015097984.issue22823@psf.upfronthosting.co.za>
In-reply-to
Content
[Isn't such changes considered code churn?]

This sort of thing is always a judgment call.  The patch will affect very few lines of code, give a little speed-up, and make the code easier to read.  In the case of the docs, it is almost always worthwhile to update to the current, idiomatic form.  Also, the set literal case is special because it has built-in language support, possible peephole optimizations, and there was a repr change as well.  That said, it is rarely a good idea to change tests because we don't have tests for tests and because the end-user will never see any value.

On the balance, I think this one is a reasonable thing to do, but I would show a great deal more hesitancy for a "a huge patch which makes Python sources to use more modern idioms."
History
Date User Action Args
2014-11-09 20:17:49rhettingersetrecipients: + rhettinger, terry.reedy, ezio.melotti, serhiy.storchaka
2014-11-09 20:17:49rhettingersetmessageid: <1415564269.36.0.990015097984.issue22823@psf.upfronthosting.co.za>
2014-11-09 20:17:49rhettingerlinkissue22823 messages
2014-11-09 20:17:49rhettingercreate