Author lemburg
Recipients Arfrever, Denis.Bilenko, alex, barry, benjamin.peterson, christian.heimes, dstufft, giampaolo.rodola, janssen, lemburg, pitrou
Date 2014-11-07.12:56:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <545CC189.4070004@egenix.com>
In-reply-to <1415362338.62.0.267410333193.issue22438@psf.upfronthosting.co.za>
Content
On 07.11.2014 13:12, Antoine Pitrou wrote:
> 
> It's not a mere matter of putting back the code... The 3.x ssl implementation which was backported uses a slightly different approach from the 2.x implementation, so it's not obvious we can recreate an entirely compatible implementation of_ssl.sslwrap().
> 
> As a matter of fact, gevent's fix uses some frame locals hackery to lookup the caller's "self" variable, which means it probably won't work in the general case:
> https://github.com/Eugeny/ajenti/commit/54442ccb2b9ee24af15500557e7dd7b2f58acb97

Yes, that hack will probably only work for gevent.

Is there a reason why caller_self needs to be passed to
context._wrap_socket() ?

I can't even find the ssl_sock kw args used in the hack in the current
2.7.9 code. The method only has a server_name argument.
History
Date User Action Args
2014-11-07 12:56:49lemburgsetrecipients: + lemburg, barry, janssen, pitrou, giampaolo.rodola, christian.heimes, benjamin.peterson, Arfrever, alex, Denis.Bilenko, dstufft
2014-11-07 12:56:49lemburglinkissue22438 messages
2014-11-07 12:56:49lemburgcreate