Author steve.dower
Recipients alexandre.vassalotti, brett.cannon, georg.brandl, kbengine, pitrou, python-dev, steve.dower, vstinner
Date 2014-11-03.16:43:16
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1415032996.59.0.790820141967.issue22676@psf.upfronthosting.co.za>
In-reply-to
Content
The fix for this now uses module without initializing it, which could lead to a crash if get_dotted_path() tries to raise an exception (it puts module into the error string with %R). See Modules/_pickle.c#l1656 and Modules/_pickle.c#l1538.

I think the fix is to initialize module with Py_None and currently there's no need to bump the refcount (though I'm always wary of doing that in case things change in the future). If that sounds right I'm happy to put the fix in, else Antoine can do it :)
History
Date User Action Args
2014-11-03 16:43:16steve.dowersetrecipients: + steve.dower, brett.cannon, georg.brandl, pitrou, vstinner, alexandre.vassalotti, python-dev, kbengine
2014-11-03 16:43:16steve.dowersetmessageid: <1415032996.59.0.790820141967.issue22676@psf.upfronthosting.co.za>
2014-11-03 16:43:16steve.dowerlinkissue22676 messages
2014-11-03 16:43:16steve.dowercreate