Author larstiq
Recipients ezio.melotti, hakan, larstiq, puppet, r.david.murray
Date 2014-11-01.15:52:54
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
What the patch does is replace the hard-coded address for the loopback interface with a one-time lookup.  I'd argue the hunk @@ -315,7 +316,7 @@ should be dropped.

The two arguments that motivate this change are:

  1) The address of the loopback interface is not always, binding to it may fail.
  2) The tests seem to assume localhost resolves to the same address where the server is running.

Working on this patch started with the ConnectionRefusedError that HÃ¥kan mentioned. 
Applying the patch made the ConnectionRefusedError go away, but I think we may
have solved a different problem and suppressed the real problem as a side

@r.david.murray: would the patch be acceptable on dropping said hunk, and changing the description to 
"Do not assume localhost resolves to"?

That still leaves, I think, a hidden bug somewhere in the proxy code that will surface in some corner case.
Date User Action Args
2014-11-01 15:52:54larstiqsetrecipients: + larstiq, ezio.melotti, r.david.murray, puppet, hakan
2014-11-01 15:52:54larstiqsetmessageid: <>
2014-11-01 15:52:54larstiqlinkissue22753 messages
2014-11-01 15:52:54larstiqcreate