This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Claudiu.Popa
Recipients Claudiu.Popa, donlorenzo, ezio.melotti
Date 2014-10-30.13:03:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1414674218.92.0.157774719925.issue22143@psf.upfronthosting.co.za>
In-reply-to
Content
I don't know why there's no review link for your patch. Anyway..

+        self.assertTrue(c.complete("A.foo", 0) in ['A.foo(', 'A.foobar('])
+        self.assertTrue(c.complete("A.foo", 1) in ['A.foo(', 'A.foobar('])


You can use self.assertIn for these.

+        self.assertEqual(c.complete("b.foo", 1), None)


self.assertIsNone.


Otherwise, the patch looks good to me.
History
Date User Action Args
2014-10-30 13:03:38Claudiu.Popasetrecipients: + Claudiu.Popa, donlorenzo, ezio.melotti
2014-10-30 13:03:38Claudiu.Popasetmessageid: <1414674218.92.0.157774719925.issue22143@psf.upfronthosting.co.za>
2014-10-30 13:03:38Claudiu.Popalinkissue22143 messages
2014-10-30 13:03:38Claudiu.Popacreate