This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author WanderingLogic
Recipients WanderingLogic, fornwall, freakboy3742, vstinner
Date 2014-10-27.17:34:48
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1414431288.89.0.459364940219.issue21668@psf.upfronthosting.co.za>
In-reply-to
Content
>>  audioop_ctypes_test_link_with_libm.patch 
> +                             libraries=['m'])
> Why not using math_libs here?

math_libs is defined in detect_modules().  But the _ctypes_test
extension is defined in a different function: detect_ctypes().

The other option, would be to define math_libs=['m'] directly above this line and then use it once.  I didn't think that added clarity, but I'd be happy to do it that way if it fits better with standard style.

> It would also be nice to add a comment explaining why libm is needed in each module.

Done.

> Can someone please combine both patches?

Done.
History
Date User Action Args
2014-10-27 17:34:48WanderingLogicsetrecipients: + WanderingLogic, vstinner, freakboy3742, fornwall
2014-10-27 17:34:48WanderingLogicsetmessageid: <1414431288.89.0.459364940219.issue21668@psf.upfronthosting.co.za>
2014-10-27 17:34:48WanderingLogiclinkissue21668 messages
2014-10-27 17:34:48WanderingLogiccreate