Message230080
>> audioop_ctypes_test_link_with_libm.patch
> + libraries=['m'])
> Why not using math_libs here?
math_libs is defined in detect_modules(). But the _ctypes_test
extension is defined in a different function: detect_ctypes().
The other option, would be to define math_libs=['m'] directly above this line and then use it once. I didn't think that added clarity, but I'd be happy to do it that way if it fits better with standard style.
> It would also be nice to add a comment explaining why libm is needed in each module.
Done.
> Can someone please combine both patches?
Done. |
|
Date |
User |
Action |
Args |
2014-10-27 17:34:48 | WanderingLogic | set | recipients:
+ WanderingLogic, vstinner, freakboy3742, fornwall |
2014-10-27 17:34:48 | WanderingLogic | set | messageid: <1414431288.89.0.459364940219.issue21668@psf.upfronthosting.co.za> |
2014-10-27 17:34:48 | WanderingLogic | link | issue21668 messages |
2014-10-27 17:34:48 | WanderingLogic | create | |
|