Author serhiy.storchaka
Recipients ezio.melotti, michael.foord, pitrou, python-dev, serhiy.storchaka, vstinner
Date 2014-10-13.08:23:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <4875422.u3kAFym9Ol@raxxla>
In-reply-to <1413151426.05.0.0213257079959.issue22390@psf.upfronthosting.co.za>
Content
> I don't understand why you want to remove more files than before. You may
> open a different issue, or at least explain the rationale.

I thought it would be good idea slightly extend this cleanup while we are 
here. I'm not motivated enough to open a different issue.

Well, here is a patch which removes only TESTFN. It is still improved, uses 
support.unlink and support.rmtree instead of os.unlink and shutil.rmtree.

You can just drop cleanup code at all if you prefer. All is good to me.

> I never see any forgotten test file after running tests, so I don't see why
> you are worried because of them.

This is because regrtest creates temporary directory and goes to it. But when 
you execute Python test directly, test files are created in the current 
directory.

> And with your first patch, we will now
> noticed forgotten files, so we can just fix tests.

But we will noticed only one about test at the time if several tests forgot 
the same file. This will needed several iterations.
Files
File name Uploaded
regrtest_warn_lost_files2.patch serhiy.storchaka, 2014-10-13.08:23:05
History
Date User Action Args
2014-10-13 08:23:05serhiy.storchakasetrecipients: + serhiy.storchaka, pitrou, vstinner, ezio.melotti, michael.foord, python-dev
2014-10-13 08:23:05serhiy.storchakalinkissue22390 messages
2014-10-13 08:23:05serhiy.storchakacreate