This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients Arfrever, Emil.Lind, akuchling, barry, benjamin.peterson, christian.heimes, georg.brandl, giampaolo.rodola, larry, python-dev, r.david.murray, vstinner
Date 2014-09-30.14:11:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1412086268.15.0.131629363815.issue16039@psf.upfronthosting.co.za>
In-reply-to
Content
> New changeset 5d1c03316af7 by Georg Brandl in branch '3.2':
> Issue #16039: CVE-2013-1752: Change use of readline in imaplib module to limit
> https://hg.python.org/cpython/rev/5d1c03316af7

I'm not sure that this change is correct, the test failed on Windows. Or maybe, it's just an issue with test test?

http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/5168/steps/test/logs/stdio

======================================================================
ERROR: test_connect (test.test_smtpnet.SmtpSSLTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_smtpnet.py", line 16, in test_connect
    server = smtplib.SMTP_SSL(self.testServer, self.remotePort)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\smtplib.py", line 862, in __init__
    SMTP.__init__(self, host, port, local_hostname, timeout)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\smtplib.py", line 260, in __init__
    (code, msg) = self.connect(host, port)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\smtplib.py", line 321, in connect
    (code, msg) = self.getreply()
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\smtplib.py", line 367, in getreply
    line = self.file.readline(_MAXLINE + 1)
TypeError: readline() takes exactly 1 positional argument (2 given)
History
Date User Action Args
2014-09-30 14:11:08vstinnersetrecipients: + vstinner, barry, akuchling, georg.brandl, larry, giampaolo.rodola, christian.heimes, benjamin.peterson, Arfrever, r.david.murray, python-dev, Emil.Lind
2014-09-30 14:11:08vstinnersetmessageid: <1412086268.15.0.131629363815.issue16039@psf.upfronthosting.co.za>
2014-09-30 14:11:08vstinnerlinkissue16039 messages
2014-09-30 14:11:07vstinnercreate