Message227800
Berker: I had some review comments pending on the docs, but reitveld isn't letting me publish them for some reason (it says the patch set doesn't exist).
The comments are: the method docs should probably say "``False`` or ``0`` (the default)" (and all the numbers should be marked up as code), and the versionchanged I think should say that the option was changed to a multilevel value.
Otherwise the patch looks good to me, too. |
|
Date |
User |
Action |
Args |
2014-09-29 14:34:33 | r.david.murray | set | recipients:
+ r.david.murray, ezio.melotti, eric.araujo, steven.daprano, takluyver, berker.peksag |
2014-09-29 14:34:33 | r.david.murray | set | messageid: <1412001273.5.0.706283375014.issue21338@psf.upfronthosting.co.za> |
2014-09-29 14:34:33 | r.david.murray | link | issue21338 messages |
2014-09-29 14:34:33 | r.david.murray | create | |
|