Message 227598 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	scoder
Recipients	mark.dickinson, pitrou, scoder, serhiy.storchaka, vstinner
Date	2014-09-26.09:08:42
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1411722522.94.0.131797780925.issue22501@psf.upfronthosting.co.za>
In-reply-to

Content
> Any optimization requires a benchmark. What is the speedup? I gave numbers in ticket #22464. """ Since many Fraction input values can already be normalised for some reason, the following change shaves off almost 30% of the calls to PyNumber_InPlaceFloorDivide() in the telco benchmark during Fraction instantiation according to callgrind, thus saving 20% of the CPU instructions that go into tp_new(). """ I then proposed to move this into the PyLong type in general, rather than letting Fraction itself do it less efficiently.

> Any optimization requires a benchmark. What is the speedup?

I gave numbers in ticket #22464.

"""
Since many Fraction input values can already be normalised for some reason, the following change shaves off almost 30% of the calls to PyNumber_InPlaceFloorDivide() in the telco benchmark during Fraction instantiation according to callgrind, thus saving 20% of the CPU instructions that go into tp_new().
"""

I then proposed to move this into the PyLong type in general, rather than letting Fraction itself do it less efficiently.

History
Date	User	Action	Args
2014-09-26 09:08:42	scoder	set	recipients: + scoder, mark.dickinson, pitrou, vstinner, serhiy.storchaka
2014-09-26 09:08:42	scoder	set	messageid: <1411722522.94.0.131797780925.issue22501@psf.upfronthosting.co.za>
2014-09-26 09:08:42	scoder	link	issue22501 messages
2014-09-26 09:08:42	scoder	create