Author lemburg
Recipients brett.cannon, lemburg, ncoghlan, pitrou, python-dev, serhiy.storchaka, vstinner, zach.ware
Date 2014-09-15.13:29:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <5416E9C4.9080201@egenix.com>
In-reply-to <1410787150.57.0.644026653048.issue22166@psf.upfronthosting.co.za>
Content
On 15.09.2014 15:19, STINNER Victor wrote:
> 
> STINNER Victor added the comment:
> 
> IMO test_codecs_fix1.patch is still needed.
> 
> Review of Nick's change:
> 
> +    interp = PyThreadState_GET()->interp;
> +    if (interp->codec_search_path == NULL) {
> +        return -1;
> +    }
> 
> I don't think that this line raises an exception.

Agreed.

Please also add some documentation to the codecs.h file and
perhaps a test for the function itself ;-)
History
Date User Action Args
2014-09-15 13:29:44lemburgsetrecipients: + lemburg, brett.cannon, ncoghlan, pitrou, vstinner, python-dev, zach.ware, serhiy.storchaka
2014-09-15 13:29:44lemburglinkissue22166 messages
2014-09-15 13:29:44lemburgcreate