Author vstinner
Recipients python-dev, serhiy.storchaka, vstinner
Date 2014-09-05.08:56:50
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1409907411.08.0.35468479469.issue22215@psf.upfronthosting.co.za>
In-reply-to
Content
> If there are no objections I'll commit the patch soon.

Replacing TypeError with ValueError is fine. TypeError was a bad choice. If an application relies on TypeError to check for null character, it's easy to replace "except TypeError:" with "except (TypeError, ValueError):" to stay compatible with Python < 3.5.

Instead of "NUL character" (and "NUL byte), I had prefer "null character" (and "null byte"):
http://en.wikipedia.org/wiki/Null_character

I talking about the error message because you changed it in a few places.
History
Date User Action Args
2014-09-05 08:56:51vstinnersetrecipients: + vstinner, python-dev, serhiy.storchaka
2014-09-05 08:56:51vstinnersetmessageid: <1409907411.08.0.35468479469.issue22215@psf.upfronthosting.co.za>
2014-09-05 08:56:51vstinnerlinkissue22215 messages
2014-09-05 08:56:50vstinnercreate