Author raduv
Recipients Arfrever, akuchling, barry, benjamin.peterson, christian.heimes, georg.brandl, giampaolo.rodola, inc0, josiahcarlson, larry, neologix, pitrou, python-dev, raduv, serhiy.storchaka, stutzbach
Date 2014-09-03.12:20:28
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1409746828.37.0.79369226968.issue16038@psf.upfronthosting.co.za>
In-reply-to
Content
I'm a little confused about this patch. Please correct me if I'm wrong, but fp.readline([size + 1]) should return a line of length at most size + 1. This means that the check len(line) > size will always be true when reading a line that has a length greater than self.maxline. Also, wouldn't it make more sense to have the line that logs stuff in debugging mode be before raising a LineTooLong exception ? This way you have the option of actually seeing the line.
History
Date User Action Args
2014-09-03 12:20:28raduvsetrecipients: + raduv, barry, akuchling, georg.brandl, josiahcarlson, pitrou, larry, giampaolo.rodola, christian.heimes, benjamin.peterson, stutzbach, Arfrever, neologix, python-dev, serhiy.storchaka, inc0
2014-09-03 12:20:28raduvsetmessageid: <1409746828.37.0.79369226968.issue16038@psf.upfronthosting.co.za>
2014-09-03 12:20:28raduvlinkissue16038 messages
2014-09-03 12:20:28raduvcreate