Author martin.panter
Recipients Ankur.Ankan, Lita.Cho, berker.peksag, ezio.melotti, jesstess, martin.panter, mattrope, pitrou
Date 2014-08-22.02:48:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1408675680.99.0.500922491725.issue1186900@psf.upfronthosting.co.za>
In-reply-to
Content
Some more points:

* I suggest adding something like this to the documentation:

exception nntplib.NNTPConnect[ion]Error
  Exception raised when the server unexpectedly shuts down the connection.

* The tests should use BytesIO rather than StringIO. Other than that, I think monkey-patching the file attribute in the tests is fine; that’s probably the way I would do it!

* The new exception should be added to __all__.
History
Date User Action Args
2014-08-22 02:48:01martin.pantersetrecipients: + martin.panter, pitrou, mattrope, ezio.melotti, jesstess, berker.peksag, Ankur.Ankan, Lita.Cho
2014-08-22 02:48:00martin.pantersetmessageid: <1408675680.99.0.500922491725.issue1186900@psf.upfronthosting.co.za>
2014-08-22 02:48:00martin.panterlinkissue1186900 messages
2014-08-22 02:48:00martin.pantercreate