Message225638
Some more points:
* I suggest adding something like this to the documentation:
exception nntplib.NNTPConnect[ion]Error
Exception raised when the server unexpectedly shuts down the connection.
* The tests should use BytesIO rather than StringIO. Other than that, I think monkey-patching the file attribute in the tests is fine; that’s probably the way I would do it!
* The new exception should be added to __all__. |
|
Date |
User |
Action |
Args |
2014-08-22 02:48:01 | martin.panter | set | recipients:
+ martin.panter, pitrou, mattrope, ezio.melotti, jesstess, berker.peksag, Ankur.Ankan, Lita.Cho |
2014-08-22 02:48:00 | martin.panter | set | messageid: <1408675680.99.0.500922491725.issue1186900@psf.upfronthosting.co.za> |
2014-08-22 02:48:00 | martin.panter | link | issue1186900 messages |
2014-08-22 02:48:00 | martin.panter | create | |
|