Author r.david.murray
Recipients barry, jesstess, pitrou, r.david.murray, zvyn
Date 2014-08-09.15:43:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1407599036.09.0.966248174318.issue21725@psf.upfronthosting.co.za>
In-reply-to
Content
I tweaked your additions.  Instead of trying to strip out the 'b' to make things "look pretty", I think it is better to print them and thus make it explicit when we are dealing with binary data and when we are dealing with strings.  It also clues the user in to the fact that the escaping inside the string is that used for bytes display, as opposed to string display.  I also expanded the tests to include headers so that the 'X-Peer' header addition would get tested.  This reveals a bug; whether it is in the tests or the code I don't know: the value of self.peer in the process_ methods is 'peer', not the expected ('b', 0).  If you can look in to this issue it would be great.

That looks like the last issue that needs to be addressed before commit.

(Oh, yeah, and there was a bug in the original process_message code...it was printing an extra blank line at the end of the message text if there was, as there should be, a newline at the end of the message...I fixed that by switching to splitlines instead of split.)
History
Date User Action Args
2014-08-09 15:43:57r.david.murraysetrecipients: + r.david.murray, barry, pitrou, jesstess, zvyn
2014-08-09 15:43:56r.david.murraysetmessageid: <1407599036.09.0.966248174318.issue21725@psf.upfronthosting.co.za>
2014-08-09 15:43:56r.david.murraylinkissue21725 messages
2014-08-09 15:43:55r.david.murraycreate