This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vajrasky
Recipients neologix, serhiy.storchaka, vajrasky, vstinner
Date 2014-08-07.14:33:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Victor, your patch fixes most of the pesky warnings. However you left one warning left (at least in Mac OS X 10.9.4).

Objects/unicodeobject.c:4831:43: warning: comparison of integers of different signs: 'unsigned long' and 'long' [-Wsign-compare]
    if (PY_SSIZE_T_MAX /  sizeof(wchar_t) < (size + 1))
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~

Maybe we can fix it by doing this:
    if (PY_SSIZE_T_MAX / (Py_ssize_t)sizeof(wchar_t) < (size + 1))
        return NULL;
Date User Action Args
2014-08-07 14:33:39vajraskysetrecipients: + vajrasky, vstinner, neologix, serhiy.storchaka
2014-08-07 14:33:39vajraskysetmessageid: <>
2014-08-07 14:33:39vajraskylinkissue22156 messages
2014-08-07 14:33:38vajraskycreate