Author glyph
Recipients Ben.Darnell, christian.heimes, dstufft, ezio.melotti, geertj, giampaolo.rodola, glyph, gvanrossum, janssen, pitrou, sbt, vstinner, yselivanov
Date 2014-08-06.17:13:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1407345186.35.0.141212348574.issue21965@psf.upfronthosting.co.za>
In-reply-to
Content
I don't have a whole lot to add.  I strongly recommended that this be done this way twice, once when ssl was added to Python and once when ssl was added to tulip, so I'm glad to see it's happening now.  Regarding the specific implementation I am unlikely to have the interest in reviewing the code because I already have a working TLS implementation which does this.  Nevertheless, if it works to get the proactor interfaces to support SSL, then it is almost certainly adequate.

It would be great to eliminate the dependency on OpenSSL's writing-to-a-socket code entirely; Python already knows how to write to a socket, and it probably knows how to do it better than OpenSSL does.

My only further input is that this code should all be deleted and replaced with pyOpenSSL or at least a separate thin wrapper over PyCA's Cryptography bindings.  My Cassandra complex and I look forward to this advice becoming obvious to everyone else in 5-7 years :-).  In the meanwhile, I will de-nosy myself.
History
Date User Action Args
2014-08-06 17:13:06glyphsetrecipients: + glyph, gvanrossum, geertj, janssen, pitrou, vstinner, giampaolo.rodola, christian.heimes, ezio.melotti, sbt, Ben.Darnell, yselivanov, dstufft
2014-08-06 17:13:06glyphsetmessageid: <1407345186.35.0.141212348574.issue21965@psf.upfronthosting.co.za>
2014-08-06 17:13:06glyphlinkissue21965 messages
2014-08-06 17:13:05glyphcreate