This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients gvanrossum, loewis, ncoghlan, neologix, pitrou, serhiy.storchaka, vstinner
Date 2014-08-04.16:10:59
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
> 2. directly passing the ASCII string to setipaddr (leaving any error detection to this routine)

This will change the type of exception. If this is acceptable and modulo Antoine's and my nitpicks on Rietveld, the patch LGTM.

But it is too complicated. Here is alternative. It has many flaws (less extensible, incompatible with Argument Clinic, can produce inaccurate error message, etc), but it is much simpler. And preserve the type of exception.
Date User Action Args
2014-08-04 16:11:00serhiy.storchakasetrecipients: + serhiy.storchaka, gvanrossum, loewis, ncoghlan, pitrou, vstinner, neologix
2014-08-04 16:11:00serhiy.storchakasetmessageid: <>
2014-08-04 16:11:00serhiy.storchakalinkissue22127 messages
2014-08-04 16:11:00serhiy.storchakacreate