Message224740
> 2. directly passing the ASCII string to setipaddr (leaving any error detection to this routine)
This will change the type of exception. If this is acceptable and modulo Antoine's and my nitpicks on Rietveld, the patch LGTM.
But it is too complicated. Here is alternative. It has many flaws (less extensible, incompatible with Argument Clinic, can produce inaccurate error message, etc), but it is much simpler. And preserve the type of exception. |
|
Date |
User |
Action |
Args |
2014-08-04 16:11:00 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, gvanrossum, loewis, ncoghlan, pitrou, vstinner, neologix |
2014-08-04 16:11:00 | serhiy.storchaka | set | messageid: <1407168660.05.0.728968480163.issue22127@psf.upfronthosting.co.za> |
2014-08-04 16:11:00 | serhiy.storchaka | link | issue22127 messages |
2014-08-04 16:11:00 | serhiy.storchaka | create | |
|