Author akira
Recipients akira, neologix, pitrou, vstinner
Date 2014-07-28.14:52:45
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <87sillilhi.fsf@gmail.com>
In-reply-to <1406551160.89.0.051155539073.issue22054@psf.upfronthosting.co.za> (STINNER Victor's message of "Mon, 28 Jul 2014 12:39:20 +0000")
Content
> os and socket modules already use getxxx() / setxxx() names:
>
> - os.get_inheritable() / os.set_inheritable()
> - os.getuid() / os.setuid()
> - os.getgroups() / os.setgroups()
> - os.getxattr() os.setxattr()
> - socket.gettimeout() / socket.settimeout()
> - socket.get_inheritable() / socket.set_inheritable()
> - etc.

egid, euid, gid, groups, pgid, pgrp, priority, resgid, sid, uid, xatrr,
hostname, timeout, sockopt are not boolean. Though
get_inheritable() spoils the pot.

Compare:

  if os.get_blocking(fd): # is it a bug? Does it return some mode bits?
     # Do I need stat.IS_BLK(os.get_blocking(fd)) here instead?

And:

  if os.is_blocking(fd):
     # it is clear that fd is blocking

There could be an argument that get_inheritable should be renamed to
is_inheritable instead.
History
Date User Action Args
2014-07-28 14:52:46akirasetrecipients: + akira, pitrou, vstinner, neologix
2014-07-28 14:52:46akiralinkissue22054 messages
2014-07-28 14:52:45akiracreate