This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author abarnert
Recipients Douglas.Alan, abarnert, akira, amaury.forgeotdarc, benjamin.peterson, eric.araujo, facundobatista, georg.brandl, jcon, martin.panter, ncoghlan, nessus42, pconnell, pitrou, r.david.murray, ralph.corderoy, rhettinger, wolma, ysj.ray
Date 2014-07-28.02:14:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1406513676.23.0.255736417899.issue1152248@psf.upfronthosting.co.za>
In-reply-to
Content
Akira, your patch does this:

-        self._writetranslate = newline != ''
-        self._writenl = newline or os.linesep
+        self._writetranslate = newline in (None, '\r', '\r\n')
+        self._writenl = newline if newline is not None else os.linesep

Any reason you made the second change? Why change the value assigned to _writenl for newline='\n' when you don't want to actually change the behavior for those cases? Just so you can double-check at write time that _writetranslate is never set unless _writenl is '\r', '\r\n', or os.linesep?
History
Date User Action Args
2014-07-28 02:14:36abarnertsetrecipients: + abarnert, georg.brandl, rhettinger, facundobatista, amaury.forgeotdarc, ncoghlan, pitrou, benjamin.peterson, nessus42, eric.araujo, ralph.corderoy, r.david.murray, ysj.ray, akira, Douglas.Alan, jcon, martin.panter, pconnell, wolma
2014-07-28 02:14:36abarnertsetmessageid: <1406513676.23.0.255736417899.issue1152248@psf.upfronthosting.co.za>
2014-07-28 02:14:36abarnertlinkissue1152248 messages
2014-07-28 02:14:35abarnertcreate