Author neologix
Recipients gvanrossum, loewis, neologix, pitrou, python-dev, vstinner, yselivanov
Date 2014-07-25.17:37:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAH_1eM0Lw_dsvtOw1xkm71N9ufLzcMGgws+-cKzfN+2+E4FW6g@mail.gmail.com>
In-reply-to <1406292752.96.0.155996913138.issue22018@psf.upfronthosting.co.za>
Content
> It doesn't answer to my complain: I don't want to support file descriptors on Windows anymore because file descriptors cannot be configured in non-blocking mode.

I think it does : if an exception is raised if an FD/handler is not in
non-blocking mode, this should include Windows file descriptors,
right?

> If we raise an error if FD and sockets are blocking, calling set_wakeup_fd() on a FD on Windows would always fail. So raising an exception because the integer is a file descriptor or raising an exception because the file descriptor is blocking leads to same result: FD are not more supported on Windows.

See above, I'm not sure what you're complaining about: since file
descriptors can't be made non-blocking on Windows, trying to register
them will raise an error. And since there's another issue for this, I
don't think the check belong in this patch (although it would proably
make more sense to commit the other patch first).
History
Date User Action Args
2014-07-25 17:37:40neologixsetrecipients: + neologix, gvanrossum, loewis, pitrou, vstinner, python-dev, yselivanov
2014-07-25 17:37:40neologixlinkissue22018 messages
2014-07-25 17:37:40neologixcreate