Message223977
> It doesn't answer to my complain: I don't want to support file descriptors on Windows anymore because file descriptors cannot be configured in non-blocking mode.
I think it does : if an exception is raised if an FD/handler is not in
non-blocking mode, this should include Windows file descriptors,
right?
> If we raise an error if FD and sockets are blocking, calling set_wakeup_fd() on a FD on Windows would always fail. So raising an exception because the integer is a file descriptor or raising an exception because the file descriptor is blocking leads to same result: FD are not more supported on Windows.
See above, I'm not sure what you're complaining about: since file
descriptors can't be made non-blocking on Windows, trying to register
them will raise an error. And since there's another issue for this, I
don't think the check belong in this patch (although it would proably
make more sense to commit the other patch first). |
|
Date |
User |
Action |
Args |
2014-07-25 17:37:40 | neologix | set | recipients:
+ neologix, gvanrossum, loewis, pitrou, vstinner, python-dev, yselivanov |
2014-07-25 17:37:40 | neologix | link | issue22018 messages |
2014-07-25 17:37:40 | neologix | create | |
|