Author vstinner
Recipients neologix, pitrou, pturing, python-dev, sbt, vstinner
Date 2014-07-24.08:49:10
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAMpsgwbEAERse0gf1vBevcx2PKfXOYKSvyBX_dT5AjMYvUcVvQ@mail.gmail.com>
In-reply-to <CAH_1eM0hX9b2kpVkOJMUDExhOwBJ9S=57-2zp44CJfHHyqH8Lw@mail.gmail.com>
Content
2014-07-24 10:11 GMT+02:00 Charles-Fran├žois Natali <report@bugs.python.org>:
>> Please also fix socketpair() in asyncio to add the while/drop unknown
>> connection (well, the function in socket.py and windows_utils.py must
>> be the same).
>
> That's a separate issue.

Ok.

>> Oh, and you forgot to modify the documentation to update
>> "Availability". Please add a ".. versionchanged:: 3.5" mentionning
>> that the function is now also available on Windows.
>
> Did you look at the patch?
>
> 363 .. versionchanged:: 3.5
> 364 Windows support added

Ok, I missed this part.

In this case, socketpair-4.diff looks good to me. You can commit your
patch in Python 3.5.

I will open another issue to synchronize asyncio, maybe fix accept()
to check the address and drop the "if proto != 0:" test.
History
Date User Action Args
2014-07-24 08:49:10vstinnersetrecipients: + vstinner, pitrou, neologix, python-dev, sbt, pturing
2014-07-24 08:49:10vstinnerlinkissue18643 messages
2014-07-24 08:49:10vstinnercreate