Message223817
> By the way, we should reuse socket.socketpair() in
> asyncio.windows_utils. The Tulip is written for Python 3.3 and shares
> exactly the same code base, so you should write
>
> Something like:
>
> if hasattr(socket, 'socketpair'):
> socketpair = socket.socketpair
> else:
> def socketpair(...): ...
>
> Please also fix socketpair() in asyncio to add the while/drop unknown
> connection (well, the function in socket.py and windows_utils.py must
> be the same).
That's a separate issue.
> Oh, and you forgot to modify the documentation to update
> "Availability". Please add a ".. versionchanged:: 3.5" mentionning
> that the function is now also available on Windows.
Did you look at the patch?
363 .. versionchanged:: 3.5
364 Windows support added |
|
Date |
User |
Action |
Args |
2014-07-24 08:11:52 | neologix | set | recipients:
+ neologix, pitrou, vstinner, python-dev, sbt, pturing |
2014-07-24 08:11:52 | neologix | link | issue18643 messages |
2014-07-24 08:11:52 | neologix | create | |
|