Author neologix
Recipients neologix, pitrou, pturing, python-dev, sbt, vstinner
Date 2014-07-24.08:11:52
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAH_1eM0hX9b2kpVkOJMUDExhOwBJ9S=57-2zp44CJfHHyqH8Lw@mail.gmail.com>
In-reply-to <CAMpsgwaf3Yv17ZhQxKyTjicPffp-aCsXBnZCKmGwx8YXshhYFw@mail.gmail.com>
Content
> By the way, we should reuse socket.socketpair() in
> asyncio.windows_utils. The Tulip is written for Python 3.3 and shares
> exactly the same code base, so you should write
>
> Something like:
>
> if hasattr(socket, 'socketpair'):
>     socketpair = socket.socketpair
> else:
>   def socketpair(...): ...
>
> Please also fix socketpair() in asyncio to add the while/drop unknown
> connection (well, the function in socket.py and windows_utils.py must
> be the same).

That's a separate issue.

> Oh, and you forgot to modify the documentation to update
> "Availability". Please add a ".. versionchanged:: 3.5" mentionning
> that the function is now also available on Windows.

Did you look at the patch?

363 .. versionchanged:: 3.5
364 Windows support added
History
Date User Action Args
2014-07-24 08:11:52neologixsetrecipients: + neologix, pitrou, vstinner, python-dev, sbt, pturing
2014-07-24 08:11:52neologixlinkissue18643 messages
2014-07-24 08:11:52neologixcreate