This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author taleinat
Recipients Saimadhav.Heblikar, jesstess, taleinat, terry.reedy
Date 2014-07-11.09:08:22
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
I've reviewed the patch and made my remarks in the review tool.

These tests don't test the central functionality of Percolator nearly enough. We should test, at least:

1) That the text actually went through the filter (and not directly to the Text
2) That if a filter modifies the text, the modified text appears in the Text
3) That a filter can stop the event from continuing through the following
4) That having more than one filter modify the arguments works.
5) That not having any filters works.
6) That this doesn't only work on a Text widget's "insert" and "delete" events.

There are probably more things we should test. Take a look at what this is used
for in practice in the code for ideas.
Date User Action Args
2014-07-11 09:08:23taleinatsetrecipients: + taleinat, terry.reedy, jesstess, Saimadhav.Heblikar
2014-07-11 09:08:23taleinatsetmessageid: <>
2014-07-11 09:08:23taleinatlinkissue21939 messages
2014-07-11 09:08:22taleinatcreate