Message220811
I'm not sure whether using os.fsencoding() is a good idea. The encoding used by uname is not defined anywhere and it's possible that Python using a wrong encoding may cause the call to fail (e.g. in case the host name includes non-ASCII chars).
Then again: _syscmd_uname() is currently only used to determine the processor, which will most likely always be ASCII.
BTW: It would be good to replace all other calls to os.popen() by subprocess as well. platform.py in Python 3 no longer has the requirement to stay compatible with earlier Python 2 releases. |
|
Date |
User |
Action |
Args |
2014-06-17 09:18:50 | lemburg | set | recipients:
+ lemburg, vstinner, neologix, Tor.Colvin |
2014-06-17 09:18:50 | lemburg | set | messageid: <1402996730.68.0.955410858938.issue21772@psf.upfronthosting.co.za> |
2014-06-17 09:18:50 | lemburg | link | issue21772 messages |
2014-06-17 09:18:50 | lemburg | create | |
|