Author lemburg
Recipients Tor.Colvin, lemburg, neologix, vstinner
Date 2014-06-17.09:18:50
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1402996730.68.0.955410858938.issue21772@psf.upfronthosting.co.za>
In-reply-to
Content
I'm not sure whether using os.fsencoding() is a good idea. The encoding used by uname is not defined anywhere and it's possible that Python using a wrong encoding may cause the call to fail (e.g. in case the host name includes non-ASCII chars).

Then again: _syscmd_uname() is currently only used to determine the processor, which will most likely always be ASCII.

BTW: It would be good to replace all other calls to os.popen() by subprocess as well. platform.py in Python 3 no longer has the requirement to stay compatible with earlier Python 2 releases.
History
Date User Action Args
2014-06-17 09:18:50lemburgsetrecipients: + lemburg, vstinner, neologix, Tor.Colvin
2014-06-17 09:18:50lemburgsetmessageid: <1402996730.68.0.955410858938.issue21772@psf.upfronthosting.co.za>
2014-06-17 09:18:50lemburglinkissue21772 messages
2014-06-17 09:18:50lemburgcreate