Author Jim.Jewett
Recipients Jim.Jewett, dstufft, eric.araujo, lemburg
Date 2014-06-13.16:49:28
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
As best I can tell, this renames the original get_code to _get_code, and then delegates to it after handling the imp.PY_FROZEN case ... why not just add imp.PY_FROZEN to the if/elif chain in the original method?

I also note that the call to self._fix_name doesn't do anything helpful unless it is overridden in a subclass -- was this patch really intended as a recipe for subclasses, that avoided super for backwards compatibility?

If it is intended to go into the main branch, then someone has to decide whether it is OK to enhance despite being deprecated.

If it is just an example, then it should probably be closed with an appropriate status.  I'm guessing "not a bug", but that isn't quite right either.
Date User Action Args
2014-06-13 16:49:28Jim.Jewettsetrecipients: + Jim.Jewett, lemburg, eric.araujo, dstufft
2014-06-13 16:49:28Jim.Jewettsetmessageid: <>
2014-06-13 16:49:28Jim.Jewettlinkissue21749 messages
2014-06-13 16:49:28Jim.Jewettcreate