Author r.david.murray
Recipients Duke.Dougal, Illirgway, barry, jesstess, lpolzer, maciej.szulik, python-dev, r.david.murray, richard, sreepriya, vstinner, zvyn
Date 2014-06-11.15:25:23
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1402500323.26.0.425542492034.issue19662@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks, Maciej. 

I tweaked the patch a bit, you might want to take a look just for your own information.  Mostly I fixed the warning stuff, which I didn't explain very well.  The idea is that if the default is used (no value is specified), we want there to be a warning.  But if a value *is* specified, there should be no warning (the user knows what they want).  To accomplish that we make the actual default value None, and check for that.  I also had to modify the tests so that warnings aren't issued, as well as test that they actually get issued when the default is used.

I also added versionchanged directives and a whatsnew entry, and expanded the decode_data docs a bit.
History
Date User Action Args
2014-06-11 15:25:23r.david.murraysetrecipients: + r.david.murray, barry, richard, vstinner, jesstess, python-dev, maciej.szulik, lpolzer, Illirgway, Duke.Dougal, zvyn, sreepriya
2014-06-11 15:25:23r.david.murraysetmessageid: <1402500323.26.0.425542492034.issue19662@psf.upfronthosting.co.za>
2014-06-11 15:25:23r.david.murraylinkissue19662 messages
2014-06-11 15:25:23r.david.murraycreate