➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author giampaolo.rodola
Recipients akira, asvetlov, christian.heimes, giampaolo.rodola, gvanrossum, josh.r, josiah.carlson, neologix, pitrou, rosslagerwall, yselivanov
Date 2014-06-07.10:22:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1402136531.63.0.346672161697.issue17552@psf.upfronthosting.co.za>
In-reply-to
Content 
Looking back at this I think a "send_blocksize" argument is necessary after all. shutil.copyfileobj() has it, so is ftplib.FTP.storbinary() and  httplib (issue 13559) which will both be using socket.sendfile() once it gets included.
Updated patch is in attachment. If there are no other objections I'd be for committing this next week or something as I'm pretty confident with the current implementation.
History
Date User Action Args
2014-06-07 10:22:12giampaolo.rodolasetrecipients: + giampaolo.rodola, gvanrossum, pitrou, christian.heimes, josiah.carlson, asvetlov, neologix, akira, rosslagerwall, yselivanov, josh.r
2014-06-07 10:22:11giampaolo.rodolasetmessageid: <1402136531.63.0.346672161697.issue17552@psf.upfronthosting.co.za>
2014-06-07 10:22:11giampaolo.rodolalinkissue17552 messages
2014-06-07 10:22:11giampaolo.rodolacreate