Author Saimadhav.Heblikar
Recipients Saimadhav.Heblikar, jesstess, terry.reedy
Date 2014-06-04.14:59:19
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1401893962.75.0.124350706996.issue21588@psf.upfronthosting.co.za>
In-reply-to
Content
Attaching a patch to make title bar user configurable.

In this patch
The title bar is configurable for PyShellEditorWindow(EditorWindow), PyShell and OutputWindow. 
The user may add the following parameters -

        py_major_version (3)
        py_minor_version (4)
        py_patchlevel (1+)
        tk_version (8.5)
        tcl_version (8.5)
        filename (sample.py)
        dir_path (/media/dev/)
        full_path (/media/dev/sample.py)
        modified_asterik (if/not saved '*')

These parameters are configurable by going to "options"->"configure idle"->"general tab"->"configure"
The above parameters have to inserted between {} as {tk_version}

The fetching of title is done by a utility function called get_title.
Redundant methods short_title and long_title have been removed.

Default config titles for PyShellEditorWindow, PyShell and OutputWindow have been inserted into config-main.def. This is based on my preferences. It may be very different from what the community/idle userbase requires. These settings have to be changed to suit the tastes of community/idle userbase.

A new module called configTitle. This contains a getTitleDialog class. It is modeled along the lines of cfgSectionNameDialog and cfgSectionHelpSourceEdit dialog. 

In configDialog.py,in "general tab", a new section for configuring title bar has been added. Clicking "configure" brings up a "getTitleDialog" dialog, where the user can modify the title. A simple validity check is also performed. As best possible, the GUI additions are in close sync with the existing code around it(except in ConfigureTitleBar).

And to whats missing,
1. Bettor error messages could be shown to user
2. Better help text to user in the config dialog,
3. Better UI/UX for configDialog
4. Tests!
5. ConfigureTitleBar() could be rewritten, say once we have a good picture of whats needed/not needed/to be removed etc.
History
Date User Action Args
2014-06-04 14:59:22Saimadhav.Heblikarsetrecipients: + Saimadhav.Heblikar, terry.reedy, jesstess
2014-06-04 14:59:22Saimadhav.Heblikarsetmessageid: <1401893962.75.0.124350706996.issue21588@psf.upfronthosting.co.za>
2014-06-04 14:59:22Saimadhav.Heblikarlinkissue21588 messages
2014-06-04 14:59:22Saimadhav.Heblikarcreate