Author Claudiu.Popa
Recipients Claudiu.Popa
Date 2014-06-02.14:55:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1401720942.39.0.48870811951.issue21641@psf.upfronthosting.co.za>
In-reply-to
Content
Hello!

I noticed that test_smtplib raises a ResourceWarning, tracking this to this piece of code:

   self.assertRaises(smtplib.SMTPResponseException, smtplib.SMTP,
                     HOST, self.port, 'localhost', 3)

What happens is that `SMTP.getreply` is called in `SMTP.__init__` after the socket was opened, but if getreply raises SMTPResponseException, the socket remains opened. The attached patch fixes this.
History
Date User Action Args
2014-06-02 14:55:42Claudiu.Popasetrecipients: + Claudiu.Popa
2014-06-02 14:55:42Claudiu.Popasetmessageid: <1401720942.39.0.48870811951.issue21641@psf.upfronthosting.co.za>
2014-06-02 14:55:42Claudiu.Popalinkissue21641 messages
2014-06-02 14:55:42Claudiu.Popacreate