Author serhiy.storchaka
Recipients Arfrever, benjamin.peterson, ezio.melotti, giampaolo.rodola, serhiy.storchaka, vstinner
Date 2014-05-24.20:50:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <2793019.LX2NAr7MII@raxxla>
In-reply-to <1400950802.22.0.0647327832235.issue18695@psf.upfronthosting.co.za>
Content
> > You have eaten "return NULL;" in posix_mkfifo.
> What do you mean?

You deleted "return NULL;" after "if (!PyArg_ParseTuple(...))" in the 
posix_mkfifo() function.

> > Tests should check that results for unicode filename is same as for str
> > filename.
> What do you mean? Can you provide an example?

For example test_statvfs should check that os.statvfs(TESTFN_UNICODE) == 
os.statvfs(TESTFN_UNICODE_ENCODED) (where TESTFN_UNICODE_ENCODED is relevant 
8-bit str).
History
Date User Action Args
2014-05-24 20:50:17serhiy.storchakasetrecipients: + serhiy.storchaka, vstinner, giampaolo.rodola, benjamin.peterson, ezio.melotti, Arfrever
2014-05-24 20:50:17serhiy.storchakalinkissue18695 messages
2014-05-24 20:50:17serhiy.storchakacreate