Author rhettinger
Recipients berker.peksag, pitrou, rhettinger, serhiy.storchaka
Date 2014-05-23.03:02:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1400814130.11.0.480655359609.issue21137@psf.upfronthosting.co.za>
In-reply-to
Content
The patch is just about ready to go but needs to address some failing tests:

======================================================================
FAIL: test_locked_repr (test.test_importlib.test_locks.Frozen_ModuleLockAsRLockTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/raymond/cpython/Lib/test/lock_tests.py", line 91, in test_locked_repr
    self.assertRegex(repr(lock), "<locked .* object (.*)?at .*>")
AssertionError: Regex didn't match: '<locked .* object (.*)?at .*>' not found in "_ModuleLock('some_lock') at 4438138048"

======================================================================
FAIL: test_repr (test.test_importlib.test_locks.Frozen_ModuleLockAsRLockTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/raymond/cpython/Lib/test/lock_tests.py", line 85, in test_repr
    self.assertRegex(repr(lock), "<unlocked .* object (.*)?at .*>")
AssertionError: Regex didn't match: '<unlocked .* object (.*)?at .*>' not found in "_ModuleLock('some_lock') at 4439151784"

======================================================================
FAIL: test_locked_repr (test.test_importlib.test_locks.Source_ModuleLockAsRLockTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/raymond/cpython/Lib/test/lock_tests.py", line 91, in test_locked_repr
    self.assertRegex(repr(lock), "<locked .* object (.*)?at .*>")
AssertionError: Regex didn't match: '<locked .* object (.*)?at .*>' not found in "_ModuleLock('some_lock') at 4438192312"

======================================================================
FAIL: test_repr (test.test_importlib.test_locks.Source_ModuleLockAsRLockTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/raymond/cpython/Lib/test/lock_tests.py", line 85, in test_repr
    self.assertRegex(repr(lock), "<unlocked .* object (.*)?at .*>")
AssertionError: Regex didn't match: '<unlocked .* object (.*)?at .*>' not found in "_ModuleLock('some_lock') at 4438192480"

----------------------------------------------------------------------
Ran 970 tests in 0.549s

FAILED (failures=4, skipped=7, expected failures=1)
test test_importlib failed
1 test failed:
    test_importlib
History
Date User Action Args
2014-05-23 03:02:10rhettingersetrecipients: + rhettinger, pitrou, berker.peksag, serhiy.storchaka
2014-05-23 03:02:10rhettingersetmessageid: <1400814130.11.0.480655359609.issue21137@psf.upfronthosting.co.za>
2014-05-23 03:02:10rhettingerlinkissue21137 messages
2014-05-23 03:02:09rhettingercreate