Author lemburg
Recipients alex, benjamin.peterson, christian.heimes, dstufft, gregory.p.smith, lemburg, ncoghlan, pitrou
Date 2014-05-19.09:20:36
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1400491238.03.0.842372821658.issue21304@psf.upfronthosting.co.za>
In-reply-to
Content
Some comments:

 * Python 2.7 ships with OpenSSL 0.9.8 on Windows, so the Python version will always get used on that platform, so it needs to be fast.

 * The iterations loop should use xrange instead of range

 * The .encode('ascii') in _long_to_bin() is not necessary in Python 2

 * Given that _long_to_bin() and _bin_to_long() are only used once in the function, it's better to inline the code directly.

 * bytes(buffer()) should not be necessary in Python 2, since objects with a buffer interface will usually also implement the tp_str slot used by bytes().
History
Date User Action Args
2014-05-19 09:20:38lemburgsetrecipients: + lemburg, gregory.p.smith, ncoghlan, pitrou, christian.heimes, benjamin.peterson, alex, dstufft
2014-05-19 09:20:38lemburgsetmessageid: <1400491238.03.0.842372821658.issue21304@psf.upfronthosting.co.za>
2014-05-19 09:20:37lemburglinkissue21304 messages
2014-05-19 09:20:36lemburgcreate