Logged In: YES 
user_id=14198

It is true select does return 1 for either the "can't
connect" or "connected" cases.  In the "connected" case, the
getsockopt() returns 0 - hence the function returns 0, and
WSASetLastError(0) has been called.  ie, as far as I can see
and test, the code works for both success and failure.

However, I do agree that the MS docs don't explicitly state
anywhere that what I am doing is OK, so I'm attaching a new
patch as you suggest, and which also seems to work <wink>