Author r.david.murray
Recipients barry, catalin.iacob, r.david.murray, sandro.tosi, zvyn
Date 2014-05-17.16:13:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1400343213.12.0.741082347224.issue15014@psf.upfronthosting.co.za>
In-reply-to
Content
OK, I've finally had time to review this, sorry for the delay.

The impalib mechanism is tailored to how imap works (that's the whole thing about "continuation response".  smtplib auth works a bit differently, and your adaptation looks OK to me.  The accompanying docstrings are a bit confusing, though, since they copy the imaplib language, which isn't entirely applicable.  Instead of talking about a 'continuation response', it should talk about a '334 challenge response', I think.

Also, both the imaplib and smptlib methods are named after the corresponding command names in the protocol.  So for imaplib we have 'authenticate', but for smtplib it should be 'auth'.

I also think we should expose the supported auth methods as part of the public API.

I think exposing the preferred auth list is premature, since if we are going to do that we need to have a way to add elements to that list for the users's own auth methods and we don't have that.  So let's confine this issue to adding the 'auth' method and using it in the login method.

The tests should include a new test of calling the auth method directly.
History
Date User Action Args
2014-05-17 16:13:33r.david.murraysetrecipients: + r.david.murray, barry, sandro.tosi, catalin.iacob, zvyn
2014-05-17 16:13:33r.david.murraysetmessageid: <1400343213.12.0.741082347224.issue15014@psf.upfronthosting.co.za>
2014-05-17 16:13:33r.david.murraylinkissue15014 messages
2014-05-17 16:13:32r.david.murraycreate