Author rhettinger
Recipients ethan.furman, rhettinger, skip.montanaro, taleinat
Date 2014-05-13.04:24:52
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1399955093.29.0.465594066037.issue21469@psf.upfronthosting.co.za>
In-reply-to
Content
> Changes LGTM.

Thanks for the review :-)

> This module could certainly use some cleanup and updates.

Yes, the API is a mess, but I would like to be very conservative with API modifications (preferably none at all) so we don't break the code of very few people who ever cared enough to use this module.  My goal here was just to fix the risk of a false positives.

> For example, last_changed should be a property and always 
> accessed one way (instead of either .mtime() or .last_changed)
> and should be initialized to None instead of zero to avoid ambiguity,

It's too late for fixing the published API.  The time for that was when the module was introduced.

> and the and/or trick should be replaced with if/else.

Yes, would be a reasonable minor clean-up that wouldn't affect the API.

>  Would anyone review such a patch if I created one?

Yes.  Just add the one-line patch to this tracker item and I'll incorporate it with the rest.

FWIW, it is perfectly reasonable to add new well-designed API extensions.  You can post patches to the open tracker items for Bug 16099 and Bug 21475.
History
Date User Action Args
2014-05-13 04:24:53rhettingersetrecipients: + rhettinger, skip.montanaro, taleinat, ethan.furman
2014-05-13 04:24:53rhettingersetmessageid: <1399955093.29.0.465594066037.issue21469@psf.upfronthosting.co.za>
2014-05-13 04:24:53rhettingerlinkissue21469 messages
2014-05-13 04:24:52rhettingercreate