Author taleinat
Recipients ethan.furman, rhettinger, taleinat
Date 2014-05-12.16:07:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1399910832.91.0.0563023022115.issue21469@psf.upfronthosting.co.za>
In-reply-to
Content
Changes LGTM.

This module could certainly use some cleanup and updates. For example, last_changed should be a property and always accessed one way (instead of either .mtime() or .last_changed) and should be initialized to None instead of zero to avoid ambiguity, and the and/or trick should be replaced with if/else. Would anyone review such a patch if I created one?
History
Date User Action Args
2014-05-12 16:07:12taleinatsetrecipients: + taleinat, rhettinger, ethan.furman
2014-05-12 16:07:12taleinatsetmessageid: <1399910832.91.0.0563023022115.issue21469@psf.upfronthosting.co.za>
2014-05-12 16:07:12taleinatlinkissue21469 messages
2014-05-12 16:07:12taleinatcreate