This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author kristjan.jonsson
Recipients alex.gronholm, brian.curtin, kristjan.jonsson, pitrou, r.david.murray, raruler, tim.golden
Date 2014-05-07.11:06:20
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1399460780.98.0.01905856966.issue20737@psf.upfronthosting.co.za>
In-reply-to
Content
changing long to DWORD doesn't really fix the overflow issue.
The fundamental problem is that some of the apis, e.g. WaitForSingleObject have a DWORD maximum.  so, we cannot support sleep times longer than some particular time.

Microseconds was chosen in the api because that is the resolution of the api in pthreads.

IMHO, I think it is okay to have an implicit ceiling on the timeout, e.g. some 4000 seconds.  We can add a caveat somewhere that anyone intending to sleep for extended periods of time should be prepared for a timeout occurring early, and should have his own timing logic to deal with that.

My suggestion then is to 
a) change the apis to DWORD
b) add a macro something like PyCOND_MAX_WAIT set to 2^32-1
c) properly clip the argument where we call this cunfion, e.g. in lock.acquire.
History
Date User Action Args
2014-05-07 11:06:21kristjan.jonssonsetrecipients: + kristjan.jonsson, pitrou, tim.golden, r.david.murray, brian.curtin, alex.gronholm, raruler
2014-05-07 11:06:20kristjan.jonssonsetmessageid: <1399460780.98.0.01905856966.issue20737@psf.upfronthosting.co.za>
2014-05-07 11:06:20kristjan.jonssonlinkissue20737 messages
2014-05-07 11:06:20kristjan.jonssoncreate