Author francismb
Recipients Jim.Jewett, NewerCookie, alanmcintyre, amaury.forgeotdarc, apolkosnik, berker.peksag, chuck, ethan.furman, francismb, georg.brandl, gregory.p.smith, ncoghlan, ronaldoussoren, serhiy.storchaka, terry.reedy
Date 2014-04-30.20:13:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1398888789.26.0.373110292951.issue6839@psf.upfronthosting.co.za>
In-reply-to
Content
A small question related to: "zipfile_276_filename_mismatch_v3.patch"

--- a/zipfile.py	Wed Apr 30 11:44:38 2014
+++ b/zipfile.py	Wed Apr 30 15:10:38 2014
@@ -970,10 +970,10 @@
             if fheader[_FH_EXTRA_FIELD_LENGTH]:
                 zef_file.read(fheader[_FH_EXTRA_FIELD_LENGTH])
 
-            if fname != zinfo.orig_filename:
-                raise BadZipfile, \
+            if self.debug and fname != zinfo.orig_filename:
+                print( \
                         'File name in directory "%s" and header "%s" differ.' % (
-                            zinfo.orig_filename, fname)
+                            zinfo.orig_filename, fname))

Shouldn't a change from raising an exception to a print be somewhere documented?

Thanks
History
Date User Action Args
2014-04-30 20:13:09francismbsetrecipients: + francismb, georg.brandl, terry.reedy, gregory.p.smith, ronaldoussoren, amaury.forgeotdarc, ncoghlan, alanmcintyre, NewerCookie, chuck, ethan.furman, berker.peksag, Jim.Jewett, serhiy.storchaka, apolkosnik
2014-04-30 20:13:09francismbsetmessageid: <1398888789.26.0.373110292951.issue6839@psf.upfronthosting.co.za>
2014-04-30 20:13:09francismblinkissue6839 messages
2014-04-30 20:13:09francismbcreate