Message217549
Patch version 6:
- I renamed "int zero" parameter to "int use_calloc" and move the new parameter at the first position to avoid confusion with nelem. For example, _PyObject_Alloc(ctx, 1, nbytes, 0) becomes _PyObject_Alloc(0, ctx, 1, nbytes). It also more logical to put it in the first position. In bytesobject.c, I leaved it at the parameter at the end since its meaning is different (fill bytes with zero or not) IMO.
- I removed my hack (premature optimization) "assert(nelem == 1); ... malloc(elsize);" and replaced it with a less surprising "... malloc(nelem * elsize);"
Stefan & Charles-François: I hope that the patch looks better to you. |
|
Date |
User |
Action |
Args |
2014-04-29 20:59:55 | vstinner | set | recipients:
+ vstinner, pitrou, njs, skrah, neologix, jtaylor, josh.r |
2014-04-29 20:59:54 | vstinner | set | messageid: <1398805194.98.0.957786844127.issue21233@psf.upfronthosting.co.za> |
2014-04-29 20:59:54 | vstinner | link | issue21233 messages |
2014-04-29 20:59:54 | vstinner | create | |
|