Message217538
Here's a new attempt, please let me know if this works out better.
Changes:
- Switched to CRT string functions (wcsncmp, wcscpy) instead of Windows lstrxxxW. There was no lstrncmpW.
- Switched to PyMem_Raw(Malloc|Free) and added explicit memset after allocation
- Better error handling (check arguments for NULL, check memory allocation)
- Fix possible overrun when checking if src_path starts with "\??\"
- Extensive commentary to describe the buffer sizing
Hope this works out better. I already have ideas for improvements, but I think we can try to get this in place first. |
|
Date |
User |
Action |
Args |
2014-04-29 18:58:49 | Kim.Gräsman | set | recipients:
+ Kim.Gräsman, tim.peters, terry.reedy, tim.golden, brian.curtin, python-dev |
2014-04-29 18:58:47 | Kim.Gräsman | set | messageid: <1398797927.85.0.290204071852.issue18314@psf.upfronthosting.co.za> |
2014-04-29 18:58:47 | Kim.Gräsman | link | issue18314 messages |
2014-04-29 18:58:46 | Kim.Gräsman | create | |
|