Author tim.peters
Recipients Claudiu.Popa, russellballestrini, tim.peters, zach.ware
Date 2014-04-25.03:04:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1398395054.96.0.854639279161.issue21344@psf.upfronthosting.co.za>
In-reply-to
Content
I wonder whether this new function would attract any users, given that the user already has control over the smallest ratio that will be accepted, and over the maximum number of close matches returned.  That's always been sufficient for me.

What useful thing(s) can the user do with the scores?  If there are compelling uses, in _those_ contexts are the `n` and `cutoff` arguments useful too?  Or would it, for example, be more useful to generate all (score, word) pairs and let the user filter them as they wish?  Without a concrete use case, there's no clear answer.

About existing tests for `get_close_matches()`, those are in the function's docstring.  doctest checks them.

About the new tests in the patch, note that comparing lists for equality "should be" done via AssertListEqual, not via AssertEqual.  Don't ask me why, but someone will eventually yell about it ;-)
History
Date User Action Args
2014-04-25 03:04:15tim.peterssetrecipients: + tim.peters, Claudiu.Popa, zach.ware, russellballestrini
2014-04-25 03:04:14tim.peterssetmessageid: <1398395054.96.0.854639279161.issue21344@psf.upfronthosting.co.za>
2014-04-25 03:04:14tim.peterslinkissue21344 messages
2014-04-25 03:04:14tim.peterscreate