Author josiahcarlson
Recipients Andrew.Boettcher, ajaksu2, akira, astrand, cvrebert, ericpruitt, eryksun, giampaolo.rodola, janzert, josiahcarlson, martin.panter, ooooooooo, parameter, r.david.murray, rosslagerwall, sbt, techtonik, v+python, vstinner
Date 2014-04-17.07:08:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1397718486.03.0.829407142933.issue1191964@psf.upfronthosting.co.za>
In-reply-to
Content
Victor, I addressed the majority of your comments except for a couple stylistic pieces. Your annoyance with the short poll time for Windows made me re-read the docs from MS, which made me realize that my interpretation was wrong. It also made me confirm Richard Oudkerk's earlier note about ReadFile on overlapped IOs.

I left similar notes next to your comments.

On the method naming side of things, note that you can only write to "stdin", and you can only read from "stdout" or "stderr". This is documented behavior, so I believe the method names are already quite reasonable (and BDFL approved ;)).
History
Date User Action Args
2014-04-17 07:08:07josiahcarlsonsetrecipients: + josiahcarlson, astrand, parameter, vstinner, techtonik, giampaolo.rodola, ajaksu2, ooooooooo, v+python, r.david.murray, cvrebert, ericpruitt, akira, Andrew.Boettcher, rosslagerwall, sbt, martin.panter, janzert, eryksun
2014-04-17 07:08:06josiahcarlsonsetmessageid: <1397718486.03.0.829407142933.issue1191964@psf.upfronthosting.co.za>
2014-04-17 07:08:06josiahcarlsonlinkissue1191964 messages
2014-04-17 07:08:05josiahcarlsoncreate