Author orsenthil
Recipients benjamin.peterson, cameron, ethan.furman, martin.panter, nikratio, orsenthil
Date 2014-04-14.15:40:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1397490056.07.0.842893223123.issue7776@psf.upfronthosting.co.za>
In-reply-to
Content
I verified the patch and this indeed corrects a nasty bug in sending a wrong header when doing it a lower level HTTPSConnection to proxy and set_tunnel (bad term) to the end host..I was worried as why we did not observe this earlier and it seems to me that the advertised way to do HTTPS CONNECT is via Proxy Handler or urllib.request and when doing it via a ProxyHandler, these wierdly named action (set_tunnel) happen underneath, but the skip_hosts bit is set as we got headers from the higher level method. and the host header is carried transparently to the tunnel connection request and thus we escaped this. 

The patch fixes the problem and cleans up a bit. Thanks for that , Nikolaus.

This code (http/client.py) will require more attention beyond this bug too.
History
Date User Action Args
2014-04-14 15:40:56orsenthilsetrecipients: + orsenthil, benjamin.peterson, cameron, nikratio, ethan.furman, martin.panter
2014-04-14 15:40:56orsenthilsetmessageid: <1397490056.07.0.842893223123.issue7776@psf.upfronthosting.co.za>
2014-04-14 15:40:56orsenthillinkissue7776 messages
2014-04-14 15:40:55orsenthilcreate