Message215738
On Mon, Apr 7, 2014, at 22:23, Alexander Belopolsky wrote:
>
> Alexander Belopolsky added the comment:
>
> Thanks for stepping in. From a quick look at your patch I don't see
> anything that I would do much differently.
>
> I noticed some whitespace issues in Include/token.h:
>
> -#define AT 49
> -#define RARROW 50
> -#define ELLIPSIS 51
> +#define AT 49
> +#define ATEQUAL 50
> +#define RARROW 51
> +#define ELLIPSIS 52
>
> (Are you sure you want to re-enumerate RARROW and ELLIPSIS? Why not just
> give ATEQUAL the value of 52?)
I thought it would be nicer if ATEQUAL was right after AT. |
|
Date |
User |
Action |
Args |
2014-04-08 05:25:32 | benjamin.peterson | set | recipients:
+ benjamin.peterson, belopolsky |
2014-04-08 05:25:32 | benjamin.peterson | link | issue21176 messages |
2014-04-08 05:25:32 | benjamin.peterson | create | |
|