Author benjamin.peterson
Recipients belopolsky, benjamin.peterson
Date 2014-04-08.05:25:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1396934730.24089.103958857.793986B7@webmail.messagingengine.com>
In-reply-to <1396934584.67.0.508886905643.issue21176@psf.upfronthosting.co.za>
Content
On Mon, Apr 7, 2014, at 22:23, Alexander Belopolsky wrote:
> 
> Alexander Belopolsky added the comment:
> 
> Thanks for stepping in.  From a quick look at your patch I don't see
> anything that I would do much differently.
> 
> I noticed some whitespace issues in Include/token.h:
> 
> -#define AT              49     
> -#define RARROW          50
> -#define ELLIPSIS        51
> +#define AT              49
> +#define ATEQUAL                50
> +#define RARROW          51
> +#define ELLIPSIS        52
> 
> (Are you sure you want to re-enumerate RARROW and ELLIPSIS? Why not just
> give ATEQUAL the value of 52?)

I thought it would be nicer if ATEQUAL was right after AT.
History
Date User Action Args
2014-04-08 05:25:32benjamin.petersonsetrecipients: + benjamin.peterson, belopolsky
2014-04-08 05:25:32benjamin.petersonlinkissue21176 messages
2014-04-08 05:25:32benjamin.petersoncreate