Author belopolsky
Recipients belopolsky, benjamin.peterson
Date 2014-04-08.05:23:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1396934584.67.0.508886905643.issue21176@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for stepping in.  From a quick look at your patch I don't see anything that I would do much differently.

I noticed some whitespace issues in Include/token.h:

-#define AT              49	
-#define RARROW          50
-#define ELLIPSIS        51
+#define AT              49
+#define ATEQUAL		50
+#define RARROW          51
+#define ELLIPSIS        52

(Are you sure you want to re-enumerate RARROW and ELLIPSIS? Why not just give ATEQUAL the value of 52?)
History
Date User Action Args
2014-04-08 05:23:04belopolskysetrecipients: + belopolsky, benjamin.peterson
2014-04-08 05:23:04belopolskysetmessageid: <1396934584.67.0.508886905643.issue21176@psf.upfronthosting.co.za>
2014-04-08 05:23:04belopolskylinkissue21176 messages
2014-04-08 05:23:04belopolskycreate