Author Jim.Jewett
Recipients Arfrever, Jim.Jewett, barry, benjamin.peterson, christian.heimes, flox, georg.brandl, larry, loewis, martin.panter, schmir, serhiy.storchaka
Date 2014-03-18.15:00:45
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1395154845.29.0.630667110441.issue16043@psf.upfronthosting.co.za>
In-reply-to
Content
I'm putting it back to release blocker, because 3.3 should decide whether to fix it/call it security/remove itself from the list.

The patch contains several small changes.  I like the spelling fix (gsip -> gzip) in a test method, but otherwise, I prefer the alternative solution of an additional function parameter with a default.

I would prefer that the marker for "no limit" be None, rather than -1, 0, or anything less than 0.

I also don't see the point of raising a too-much-data ValueError *after* decoding.  While that *might* mean we set the default too low, all we would really know for sure is that there would be a bug in gzip.GzipFile().read -- and ValueError suggests otherwise.
History
Date User Action Args
2014-03-18 15:00:45Jim.Jewettsetrecipients: + Jim.Jewett, loewis, barry, georg.brandl, larry, christian.heimes, schmir, benjamin.peterson, Arfrever, flox, martin.panter, serhiy.storchaka
2014-03-18 15:00:45Jim.Jewettsetmessageid: <1395154845.29.0.630667110441.issue16043@psf.upfronthosting.co.za>
2014-03-18 15:00:45Jim.Jewettlinkissue16043 messages
2014-03-18 15:00:45Jim.Jewettcreate