Message212987
Sorry, stray submit, one more time:
Thanks for the patch, Alexandre.Zani!
Your patch had some whitespace issues according to `make patchcheck` (see http://docs.python.org/devguide/patch.html#generation for details).
I've uploaded a trivial update to your patch that passes patchcheck. The patch applies cleanly and test_minidom passes.
This enhancement may need some documentation on the new constructor before getting merged, but let's get a design review going.
=> patch review |
|
Date |
User |
Action |
Args |
2014-03-09 21:27:32 | jesstess | set | recipients:
+ jesstess, exarkun, Alexandre.Zani, avono |
2014-03-09 21:27:32 | jesstess | set | messageid: <1394400452.52.0.079609365647.issue4849@psf.upfronthosting.co.za> |
2014-03-09 21:27:32 | jesstess | link | issue4849 messages |
2014-03-09 21:27:32 | jesstess | create | |
|