Author serhiy.storchaka
Recipients benjamin.peterson, docs@python, gromgull, hynek, pitrou, python-dev, r.david.murray, serhiy.storchaka, stutzbach, vajrasky, zach.ware
Date 2014-02-28.21:26:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1393622772.5.0.357776427536.issue20501@psf.upfronthosting.co.za>
In-reply-to
Content
My bad. I had cleaned patch before committing to 3.x, but forgot to revert and correct it in 2.7. Thank you Vajrasky an Zachary.

> Does it mean: "UTF-7 is an unlikely locale encoding"?

Sorry for my bad English. I meant that UTF-7 is used here because it is unlikely that it is locale encoding. Is "an" needed here?

> I would actually vote for using writeTmp, and make a new issue for making writeTmp use a context manager.

I think that explicit two-line code is better than calling superfluous function. We don't need generated filename, we write only one chunk of code, we use context manager, so the code is only two lines long.

> inside a `try ... except UnicodeDecodeError: self.fail('Read to end of file')` block.

May be, but in 2.7 a traceback doesn't contain info about original exception and this can hide necessary details in case of failure.
History
Date User Action Args
2014-02-28 21:26:12serhiy.storchakasetrecipients: + serhiy.storchaka, pitrou, benjamin.peterson, stutzbach, r.david.murray, docs@python, python-dev, gromgull, hynek, zach.ware, vajrasky
2014-02-28 21:26:12serhiy.storchakasetmessageid: <1393622772.5.0.357776427536.issue20501@psf.upfronthosting.co.za>
2014-02-28 21:26:12serhiy.storchakalinkissue20501 messages
2014-02-28 21:26:11serhiy.storchakacreate